Use ObjectDisposedException throw helper#3909
Merged
jeremydmiller merged 1 commit intoJasperFx:masterfrom Aug 19, 2025
Merged
Conversation
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1513 It seems that the second parameter need to be the full name type of the class, and the message of the exception could not be changed. But I did not want to make breaking change, even if it very small, so I passed the string as it is without any change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1513
It seems that the second parameter needs to the instance of the object (by passing
thiskeyword or the Type of the containing class), and the message of the exception can not be changed. But I did not want to make a breaking change, even if it was very small, so I passed the string as it is without any change