Skip to content

Add (failing) test ensuring that the highwater detector can detect multiple gaps #3907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremydmiller merged 1 commit into from
Aug 8, 2025
Merged

Add (failing) test ensuring that the highwater detector can detect multiple gaps #3907

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions src/DaemonTests/Internals/HighWaterAgentTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,32 @@ public async Task will_not_go_in_loop_when_sequence_is_advanced_but_gaps_from_hi
await agent2.Tracker.WaitForHighWaterMark(NumberOfEvents + 5);
}

[Fact]
public async Task skips_multiple_gaps_and_keeps_advancing()
{
NumberOfStreams = 10;
await PublishSingleThreaded();

// Create multiple gaps in the event sequence
var gaps = new[] { NumberOfEvents - 9, NumberOfEvents - 6, NumberOfEvents - 5, NumberOfEvents - 3 };
await deleteEvents(gaps);

// Make gap skipping kick in faster
theStore.Options.Projections.StaleSequenceThreshold = 1.Seconds();

using var agent = await StartDaemon();

// Expect the agent to move beyond each gap by reporting the last contiguous (safe harbor) mark
await agent.Tracker.WaitForHighWaterMark(gaps[0], 2.Seconds());
await agent.Tracker.WaitForHighWaterMark(gaps[1], 2.Seconds());
await agent.Tracker.WaitForHighWaterMark(gaps[2], 2.Seconds());
await agent.Tracker.WaitForHighWaterMark(gaps[3], 2.Seconds());
// And eventually reach the head
await agent.Tracker.WaitForHighWaterMark(NumberOfEvents, 2.Seconds());

await agent.StopAllAsync();
}

private async Task deleteEvents(params long[] ids)
{
await using var conn = theStore.CreateConnection();
Expand Down