Skip to content

Replace Count() method with Count and Length properties #3856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremydmiller merged 1 commit into from
Jul 26, 2025
Merged

Replace Count() method with Count and Length properties #3856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/DocumentDbTests/Indexes/full_text_index.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ public async Task using_full_text_query_through_query_session()

#endregion

result.Count().ShouldBe(1);
result.Count.ShouldBe(1);
}

[PgVersionTargetedFact(MinimumVersion = "10.0")]
Expand Down
6 changes: 3 additions & 3 deletions src/DocumentDbTests/Reading/BatchedQuerying/batched_querying_acceptance_Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System;
using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.Linq;
Expand Down Expand Up @@ -369,7 +369,7 @@ public async Task can_find_multiple_docs_by_id()

var list = await task;

list.Count().ShouldBe(2);
list.Count.ShouldBe(2);
list.Any(x => x.Id == target1.Id).ShouldBeTrue();
list.Any(x => x.Id == target3.Id).ShouldBeTrue();
}
Expand Down Expand Up @@ -403,7 +403,7 @@ public async Task can_find_multiple_docs_by_id_2()

var list = await task;

list.Count().ShouldBe(2);
list.Count.ShouldBe(2);
list.Any(x => x.Id == target1.Id).ShouldBeTrue();
list.Any(x => x.Id == target3.Id).ShouldBeTrue();
}
Expand Down
2 changes: 1 addition & 1 deletion src/DocumentDbTests/Reading/Json/streaming_json_results.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,7 +631,7 @@ public async Task streaming_compiled_query_list_to_JSON()
var customers = theStore.Options.Serializer().FromJson<Customer[]>(stream);
customers.Length.ShouldBe(2);

customerJson.Count().ShouldBe(148); // magic number that just happens to be the length of the JSON string returned
customerJson.Length.ShouldBe(148); // magic number that just happens to be the length of the JSON string returned
}


Expand Down
4 changes: 2 additions & 2 deletions src/DocumentDbTests/SessionMechanics/DocumentSession_change_set_tracking_Tests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System;
using System;
using System.Linq;
using System.Threading.Tasks;
using Marten.Linq.SqlGeneration;
Expand Down Expand Up @@ -58,7 +58,7 @@ public async Task categorize_changes_inserts_and_deletions()
theSession.Store(new Target());
await theSession.SaveChangesAsync();

logger.Commits.Count().ShouldBe(2);
logger.Commits.Count.ShouldBe(2);
logger.LastCommit.Updated.Count().ShouldBe(1);
}

Expand Down
4 changes: 2 additions & 2 deletions src/DocumentDbTests/Writing/Identity/using_int_identity.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System.Linq;
using System.Linq;
using System.Threading.Tasks;
using Marten.Testing.Documents;
using Marten.Testing.Harness;
Expand Down Expand Up @@ -71,7 +71,7 @@ public async Task load_by_array_of_ids()
await theSession.SaveChangesAsync();

using var session = theStore.QuerySession();
(await session.LoadManyAsync<IntDoc>(4, 5, 6)).Count().ShouldBe(3);
(await session.LoadManyAsync<IntDoc>(4, 5, 6)).Count.ShouldBe(3);
}

public using_int_identity(DefaultStoreFixture fixture) : base(fixture)
Expand Down
4 changes: 2 additions & 2 deletions src/DocumentDbTests/Writing/Identity/using_long_identity.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System.Linq;
using System.Linq;
using System.Threading.Tasks;
using Marten.Testing.Documents;
using Marten.Testing.Harness;
Expand Down Expand Up @@ -71,7 +71,7 @@ public async Task load_by_array_of_ids()
await theSession.SaveChangesAsync();

using var session = theStore.QuerySession();
(await session.LoadManyAsync<LongDoc>(4, 5, 6)).Count().ShouldBe(3);
(await session.LoadManyAsync<LongDoc>(4, 5, 6)).Count.ShouldBe(3);
}

public using_long_identity(DefaultStoreFixture fixture) : base(fixture)
Expand Down
4 changes: 2 additions & 2 deletions src/DocumentDbTests/Writing/Identity/using_string_identity.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
using System;
using System;
using System.Linq;
using System.Threading.Tasks;
using Marten.Testing.Documents;
Expand Down Expand Up @@ -95,7 +95,7 @@ public async Task load_by_array_of_ids()
await theSession.SaveChangesAsync();

using var session = theStore.QuerySession();
(await session.LoadManyAsync<Account>("A", "B", "E")).Count().ShouldBe(3);
(await session.LoadManyAsync<Account>("A", "B", "E")).Count.ShouldBe(3);
}

public using_string_identity(DefaultStoreFixture fixture) : base(fixture)
Expand Down
2 changes: 1 addition & 1 deletion src/DocumentDbTests/Writing/document_inserts.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public async Task can_insert_records()

using (var query = theStore.QuerySession())
{
query.Query<RecordDocument>().ToList().Count().ShouldBe(1);
query.Query<RecordDocument>().ToList().Count.ShouldBe(1);
}
}

Expand Down
4 changes: 2 additions & 2 deletions src/DocumentDbTests/Writing/storing_documents.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ public async Task load_by_id_array(DocumentTracking tracking)

using var querySession = theStore.QuerySession();
var users = await querySession.LoadManyAsync<User>(user2.Id, user3.Id, user4.Id);
users.Count().ShouldBe(3);
users.Count.ShouldBe(3);
}

[Theory]
Expand Down Expand Up @@ -252,7 +252,7 @@ public async Task load_by_id_array_async(DocumentTracking tracking)

await using var querySession = store.QuerySession();
var users = await querySession.LoadManyAsync<User>(user2.Id, user3.Id, user4.Id);
users.Count().ShouldBe(3);
users.Count.ShouldBe(3);

#endregion
}
Expand Down
22 changes: 11 additions & 11 deletions src/EventSourcingTests/QuickAppend/quick_append_event_capture_and_fetching_the_stream.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ await When.CalledForEachAsync(tenants, async (tenantId, _) =>

var streamEvents = await session.Events.FetchStreamAsync(id);

streamEvents.Count().ShouldBe(2);
streamEvents.Count.ShouldBe(2);
streamEvents.ElementAt(0).Data.ShouldBeOfType<MembersJoined>();
streamEvents.ElementAt(0).Version.ShouldBe(1);
streamEvents.ElementAt(1).Data.ShouldBeOfType<MembersDeparted>();
Expand Down Expand Up @@ -87,7 +87,7 @@ public Task capture_events_to_a_new_stream_and_fetch_the_events_back_async(Tenan

var streamEvents = await session.Events.FetchStreamAsync(id);

streamEvents.Count().ShouldBe(2);
streamEvents.Count.ShouldBe(2);
streamEvents.ElementAt(0).Data.ShouldBeOfType<MembersJoined>();
streamEvents.ElementAt(0).Version.ShouldBe(1);
streamEvents.ElementAt(1).Data.ShouldBeOfType<MembersDeparted>();
Expand Down Expand Up @@ -117,7 +117,7 @@ public Task capture_events_to_a_new_stream_and_fetch_the_events_back_async_with_
var streamEvents = await session.Events.QueryAllRawEvents()
.Where(x => x.StreamId == id).OrderBy(x => x.Version).ToListAsync();

streamEvents.Count().ShouldBe(2);
streamEvents.Count.ShouldBe(2);
streamEvents.ElementAt(0).Data.ShouldBeOfType<MembersJoined>();
streamEvents.ElementAt(0).Version.ShouldBe(1);
streamEvents.ElementAt(1).Data.ShouldBeOfType<MembersDeparted>();
Expand Down Expand Up @@ -147,7 +147,7 @@ public void capture_events_to_a_new_stream_and_fetch_the_events_back_sync_with_l
var streamEvents = session.Events.QueryAllRawEvents()
.Where(x => x.StreamId == id).OrderBy(x => x.Version).ToList();

streamEvents.Count().ShouldBe(2);
streamEvents.Count.ShouldBe(2);
streamEvents.ElementAt(0).Data.ShouldBeOfType<MembersJoined>();
streamEvents.ElementAt(0).Version.ShouldBe(1);
streamEvents.ElementAt(1).Data.ShouldBeOfType<MembersDeparted>();
Expand Down Expand Up @@ -280,7 +280,7 @@ await When.CalledForEachAsync(tenants, async (tenantId, index) =>

var streamEvents = await session.Events.FetchStreamAsync(id);

streamEvents.Count().ShouldBe(2);
streamEvents.Count.ShouldBe(2);
streamEvents.ElementAt(0).Data.ShouldBeOfType<MembersJoined>();
streamEvents.ElementAt(0).Version.ShouldBe(1);
streamEvents.ElementAt(1).Data.ShouldBeOfType<MembersDeparted>();
Expand Down Expand Up @@ -311,7 +311,7 @@ await When.CalledForEachAsync(tenants, async (tenantId, index) =>

var streamEvents = await session.Events.FetchStreamAsync(id);

streamEvents.Count().ShouldBe(2);
streamEvents.Count.ShouldBe(2);
streamEvents.ElementAt(0).Data.ShouldBeOfType<MembersJoined>();
streamEvents.ElementAt(0).Version.ShouldBe(1);
streamEvents.ElementAt(1).Data.ShouldBeOfType<MembersDeparted>();
Expand Down Expand Up @@ -351,7 +351,7 @@ await When.CalledForEachAsync(tenants, async (tenantId, index) =>

var streamEvents = await session.Events.FetchStreamAsync(id);

streamEvents.Count().ShouldBe(3);
streamEvents.Count.ShouldBe(3);
streamEvents.ElementAt(0).Data.ShouldBeOfType<QuestStarted>();
streamEvents.ElementAt(0).Version.ShouldBe(1);
streamEvents.ElementAt(1).Data.ShouldBeOfType<MembersJoined>();
Expand Down Expand Up @@ -384,7 +384,7 @@ await When.CalledForEachAsync(tenants, async (tenantId, index) =>

var streamEvents = await session.Events.FetchStreamAsync(id);

streamEvents.Count().ShouldBe(2);
streamEvents.Count.ShouldBe(2);
streamEvents.ElementAt(0).Data.ShouldBeOfType<MembersJoined>();
streamEvents.ElementAt(0).Version.ShouldBe(1);
streamEvents.ElementAt(1).Data.ShouldBeOfType<MembersDeparted>();
Expand Down Expand Up @@ -414,7 +414,7 @@ await When.CalledForEachAsync(tenants, async (tenantId, index) =>

var streamEvents = await session.Events.FetchStreamAsync(id);

streamEvents.Count().ShouldBe(2);
streamEvents.Count.ShouldBe(2);
streamEvents.ElementAt(0).Data.ShouldBeOfType<MembersJoined>();
streamEvents.ElementAt(0).Version.ShouldBe(1);
streamEvents.ElementAt(1).Data.ShouldBeOfType<MembersDeparted>();
Expand Down Expand Up @@ -447,7 +447,7 @@ await When.CalledForEachAsync(tenants, async (tenantId, index) =>

var streamEvents = await session.Events.FetchStreamAsync(id);

streamEvents.Count().ShouldBe(2);
streamEvents.Count.ShouldBe(2);
streamEvents.ElementAt(0).Data.ShouldBeOfType<MembersJoined>();
streamEvents.ElementAt(0).Version.ShouldBe(1);
streamEvents.ElementAt(1).Data.ShouldBeOfType<MembersDeparted>();
Expand Down Expand Up @@ -486,7 +486,7 @@ await When.CalledForEachAsync(tenants, async (tenantId, index) =>

var streamEvents = await session.Events.FetchStreamAsync(id);

streamEvents.Count().ShouldBe(3);
streamEvents.Count.ShouldBe(3);
streamEvents.ElementAt(0).Data.ShouldBeOfType<QuestStarted>();
streamEvents.ElementAt(0).Version.ShouldBe(1);
streamEvents.ElementAt(1).Data.ShouldBeOfType<MembersJoined>();
Expand Down
20 changes: 10 additions & 10 deletions ...QuickAppend/quick_append_event_capture_and_fetching_the_stream_with_string_identifiers.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public async Task capture_events_to_a_new_stream_and_fetch_the_events_back()

var streamEvents = await theSession.Events.FetchStreamAsync(id);

streamEvents.Count().ShouldBe(2);
streamEvents.Count.ShouldBe(2);
streamEvents.ElementAt(0).Data.ShouldBeOfType<MembersJoined>();
streamEvents.ElementAt(0).Version.ShouldBe(1);
streamEvents.ElementAt(1).Data.ShouldBeOfType<MembersDeparted>();
Expand All @@ -57,7 +57,7 @@ public async Task capture_events_to_a_new_stream_and_fetch_the_events_back_async

var streamEvents = await theSession.Events.FetchStreamAsync(id);

streamEvents.Count().ShouldBe(2);
streamEvents.Count.ShouldBe(2);
streamEvents.ElementAt(0).Data.ShouldBeOfType<MembersJoined>();
streamEvents.ElementAt(0).Version.ShouldBe(1);
streamEvents.ElementAt(1).Data.ShouldBeOfType<MembersDeparted>();
Expand All @@ -83,7 +83,7 @@ public async Task capture_events_to_a_new_stream_and_fetch_the_events_back_async
var streamEvents = await theSession.Events.QueryAllRawEvents()
.Where(x => x.StreamKey == id).OrderBy(x => x.Version).ToListAsync();

streamEvents.Count().ShouldBe(2);
streamEvents.Count.ShouldBe(2);
streamEvents.ElementAt(0).Data.ShouldBeOfType<MembersJoined>();
streamEvents.ElementAt(0).Version.ShouldBe(1);
streamEvents.ElementAt(1).Data.ShouldBeOfType<MembersDeparted>();
Expand All @@ -109,7 +109,7 @@ public async Task capture_events_to_a_new_stream_and_fetch_the_events_back_sync_
var streamEvents = theSession.Events.QueryAllRawEvents()
.Where(x => x.StreamKey == id).OrderBy(x => x.Version).ToList();

streamEvents.Count().ShouldBe(2);
streamEvents.Count.ShouldBe(2);
streamEvents.ElementAt(0).Data.ShouldBeOfType<MembersJoined>();
streamEvents.ElementAt(0).Version.ShouldBe(1);
streamEvents.ElementAt(1).Data.ShouldBeOfType<MembersDeparted>();
Expand Down Expand Up @@ -289,7 +289,7 @@ public async Task capture_events_to_a_new_stream_and_fetch_the_events_back_with_

var streamEvents = await session.Events.FetchStreamAsync(id);

streamEvents.Count().ShouldBe(2);
streamEvents.Count.ShouldBe(2);
streamEvents.ElementAt(0).Data.ShouldBeOfType<MembersJoined>();
streamEvents.ElementAt(0).Version.ShouldBe(1);
streamEvents.ElementAt(1).Data.ShouldBeOfType<MembersDeparted>();
Expand All @@ -311,7 +311,7 @@ public async Task capture_events_to_a_non_existing_stream_and_fetch_the_events_b

var streamEvents = await session.Events.FetchStreamAsync(id);

streamEvents.Count().ShouldBe(2);
streamEvents.Count.ShouldBe(2);
streamEvents.ElementAt(0).Data.ShouldBeOfType<MembersJoined>();
streamEvents.ElementAt(0).Version.ShouldBe(1);
streamEvents.ElementAt(1).Data.ShouldBeOfType<MembersDeparted>();
Expand Down Expand Up @@ -342,7 +342,7 @@ public async Task capture_events_to_an_existing_stream_and_fetch_the_events_back

var streamEvents = await session.Events.FetchStreamAsync(id);

streamEvents.Count().ShouldBe(3);
streamEvents.Count.ShouldBe(3);
streamEvents.ElementAt(0).Data.ShouldBeOfType<QuestStarted>();
streamEvents.ElementAt(0).Version.ShouldBe(1);
streamEvents.ElementAt(1).Data.ShouldBeOfType<MembersJoined>();
Expand All @@ -365,7 +365,7 @@ public async Task capture_events_to_a_new_stream_and_fetch_the_events_back_in_an

var streamEvents = await session.Events.FetchStreamAsync(id);

streamEvents.Count().ShouldBe(2);
streamEvents.Count.ShouldBe(2);
streamEvents.ElementAt(0).Data.ShouldBeOfType<MembersJoined>();
streamEvents.ElementAt(0).Version.ShouldBe(1);
streamEvents.ElementAt(1).Data.ShouldBeOfType<MembersDeparted>();
Expand All @@ -388,7 +388,7 @@ public async Task capture_events_to_a_non_existing_stream_and_fetch_the_events_b

var streamEvents = await session.Events.FetchStreamAsync(id);

streamEvents.Count().ShouldBe(2);
streamEvents.Count.ShouldBe(2);
streamEvents.ElementAt(0).Data.ShouldBeOfType<MembersJoined>();
streamEvents.ElementAt(0).Version.ShouldBe(1);
streamEvents.ElementAt(1).Data.ShouldBeOfType<MembersDeparted>();
Expand Down Expand Up @@ -418,7 +418,7 @@ public async Task capture_events_to_an_existing_stream_and_fetch_the_events_back

var streamEvents = await session.Events.FetchStreamAsync(id);

streamEvents.Count().ShouldBe(3);
streamEvents.Count.ShouldBe(3);
streamEvents.ElementAt(0).Data.ShouldBeOfType<QuestStarted>();
streamEvents.ElementAt(0).Version.ShouldBe(1);
streamEvents.ElementAt(1).Data.ShouldBeOfType<MembersJoined>();
Expand Down
Loading
Loading