Fix blind replace of d. in TypedLocator causing issues when schema name ends with d

src/DocumentDbTests/Bugs/Bug_3778_schema_name_issue.cs

@@ -0,0 +1,30 @@
+using System;
+using System.Threading.Tasks;
+using JasperFx;
+using Marten.Testing;
+using Marten.Testing.Harness;
+using Xunit;
+
+namespace DocumentDbTests.Bugs;
+
+public class Bug_3778_schema_name_issue: OneOffConfigurationsContext
+{
+    private string Schema = "pprd";
+
+    [Fact]
+    public async Task TestSchemaNameEndingWith_d_BeingCutOff_In_Index()
+    {
+        StoreOptions(options =>
+        {
+            options.Connection(ConnectionSource.ConnectionString);
+            options.AutoCreateSchemaObjects = AutoCreate.All;
+            options.DatabaseSchemaName = Schema;
+            options.Schema.For<User3778>()
+                .Index(d => d.Created);
+        });
+
+        await theStore.EnsureStorageExistsAsync(typeof(User3778));
+    }
+}
+
+public record User3778(Guid Id, string Name, DateTimeOffset Created);

src/Marten/Linq/Members/DateTimeMember.cs

@@ -14,7 +14,7 @@ public DateTimeMember(StoreOptions options, IQueryableMember parent, Casing casi
 
     public override string SelectorForDuplication(string pgType)
     {
-        return TypedLocator.Replace("d.", "");
+        return TypedLocator.Replace("d.data ->", "data ->");
     }
 }
 
@@ -27,7 +27,7 @@ public DateOnlyMember(StoreOptions options, IQueryableMember parent, Casing casi
 
     public override string SelectorForDuplication(string pgType)
     {
-        return TypedLocator.Replace("d.", "");
+        return TypedLocator.Replace("d.data ->", "data ->");
     }
 
 }
@@ -41,7 +41,7 @@ public TimeOnlyMember(StoreOptions options, IQueryableMember parent, Casing casi
 
     public override string SelectorForDuplication(string pgType)
     {
-        return TypedLocator.Replace("d.", "");
+        return TypedLocator.Replace("d.data ->", "data ->");
     }
 
 }

src/Marten/Linq/Members/DateTimeOffsetMember.cs

@@ -17,7 +17,7 @@ public DateTimeOffsetMember(StoreOptions options, IQueryableMember parent, Casin
 
     public override string SelectorForDuplication(string pgType)
     {
-        return TypedLocator.Replace("d.", "");
+        return TypedLocator.Replace("d.data ->", "data ->");
     }
 
     public override ISqlFragment CreateComparison(string op, ConstantExpression constant)

src/Marten/Schema/ComputedIndex.cs

@@ -83,11 +83,12 @@ private IEnumerable<string> buildColumns()
                 casing = Casings.Default;
             }
 
-            var sql = member.MemberType.IsEnumerable()
-                ? member is ChildCollectionMember ? member.TypedLocator : member.RawLocator
-                : member.TypedLocator;
+            var rawLocator = member.RawLocator.Replace("d.data ->", "data ->");
+            var typedLocator = member.TypedLocator.Replace("d.data ->", "data ->");
 
-            sql = sql.Replace("d.", "");
+            var sql = member.MemberType.IsEnumerable()
+                ? member is ChildCollectionMember ? typedLocator : rawLocator
+                : typedLocator;
 
             switch (casing)
             {

src/Marten/Schema/NgramIndex.cs

@@ -75,8 +75,7 @@ protected override string deriveIndexName()
 
     private static string GetDataConfig(DocumentMapping mapping, MemberInfo[] members)
     {
-        var dataConfig = $"{mapping.QueryMembers.MemberFor(members).TypedLocator.Replace("d.", "")}";
-
+        var dataConfig = $"{mapping.QueryMembers.MemberFor(members).TypedLocator.Replace("d.data ->", "data ->")}";
         return $"{dataConfig}";
     }
 }