Skip to content

Do NOT reuse the message batch across transactions #3784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremydmiller merged 2 commits into from
May 5, 2025
Merged

Do NOT reuse the message batch across transactions #3784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b629ea1
Forcing Marten to use a fresh messaging context in side effects on ev…
jeremydmiller May 5, 2025
6acda2e
bumping to 7.40.2
jeremydmiller May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<Project>
<PropertyGroup>
<Version>7.40.1</Version>
<Version>7.40.2</Version>
<LangVersion>12.0</LangVersion>
<Authors>Jeremy D. Miller;Babu Annamalai;Oskar Dudycz;Joona-Pekka Kokko</Authors>
<PackageIconUrl>https://martendb.io/logo.png</PackageIconUrl>
Expand Down
4 changes: 4 additions & 0 deletions src/Marten/Internal/Sessions/DocumentSessionBase.SaveChanges.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,10 @@ public async Task SaveChangesAsync(CancellationToken token = default)
if (_messageBatch != null)
{
await _messageBatch.AfterCommitAsync(this, _workTracker, token).ConfigureAwait(false);

// This is important, we need to throw this away on every commit and start w/ a fresh
// one on new transactions
_messageBatch = null;
}

resetDirtyChecking();
Expand Down