Skip to content

Conversation

@jakobt
Copy link
Contributor

@jakobt jakobt commented Mar 14, 2025

No description provided.

Copy link
Member

@mysticmind mysticmind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

@haefele
Copy link
Contributor

haefele commented Mar 15, 2025

How about the "CREATE EXTENSION IF NOT EXISTS unaccent;" in the sql? Will it work with the migrations that way?

@jakobt
Copy link
Contributor Author

jakobt commented Mar 16, 2025

How about the "CREATE EXTENSION IF NOT EXISTS unaccent;" in the sql? Will it work with the migrations that way?

This was removed and being replaced by adding the extension as an ISchemaObject that Marten automatically manages and generates code for.

@mysticmind mysticmind merged commit c784a9e into JasperFx:7.0 Mar 21, 2025
0 of 4 checks passed
jeremydmiller pushed a commit that referenced this pull request Mar 25, 2025
…#3721)

* Make sure unaccent is enabled. This slipped because the marten test suite enables it elsewhere.
* Make the extension for unaccent play nice with migrations.
* Remove test code
* Cleaning up test
* Make it mergeable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants