Skip to content

Add predicate for patching#3666

Merged
jeremydmiller merged 2 commits intoJasperFx:masterfrom
kyle69:add-predicate-for-patching
Feb 14, 2025
Merged

Add predicate for patching#3666
jeremydmiller merged 2 commits intoJasperFx:masterfrom
kyle69:add-predicate-for-patching

Conversation

@kyle69
Copy link
Contributor

@kyle69 kyle69 commented Feb 11, 2025

Proposed new patching functionality for a personal need that could be useful to other MartenDb users.

  • Possibility of deleting one or more elements according to a predicate.
  • Possibility of adding an element according to a predicate.
  • Possibility of inserting an element according to a predicate.

@mysticmind
Copy link
Member

mysticmind commented Feb 12, 2025

@kyle69 Happy to see this PR and your proposed features to the patching API. I had a brief look and it looks fine, will review it thoroughly as a next step. I also think the CI build failures are not due to your changes.

Edit: I haven't seen much questions or traction on the native patching feature since the time I added this to Marten. Either it is pretty good that everything works well or it is not discovered or used much by end users :-)

@kyle69
Copy link
Contributor Author

kyle69 commented Feb 12, 2025

@mysticmind Glad you like the feature :) I don't really understand why the build is in error.
Thanks a lot!

@jeremydmiller
Copy link
Member

@kyle69 @mysticmind I'll push through this tomorrow morning and deal w/ whatever the CI turned up. Good PR to have in for the next release.

@mysticmind
Copy link
Member

@kyle69 @mysticmind I'll push through this tomorrow morning and deal w/ whatever the CI turned up. Good PR to have in for the next release.

This PR looks fine. Go ahead.

@jeremydmiller jeremydmiller merged commit 845b6e5 into JasperFx:master Feb 14, 2025
1 of 5 checks passed
@kyle69 kyle69 deleted the add-predicate-for-patching branch February 14, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants