Add overload that allows a custom parameter placeholder. #3622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `char placeholder` param is always before the `string sql` param. This is to ensure that the overload is backwards compatible., Updated all methods that accept parameters except for: - Sync methods that are marked obsolete - `MatchesJsonPath` - This should probably be marked as obsolete as the placeholder overload does the same thing but better. Todo: - Tests.
elexisvenator
commented
Jan 11, 2025
| @@ -62,6 +114,7 @@ public interface IAdvancedSql | |||
| /// <param name="sql"></param> | |||
| /// <param name="parameters"></param> | |||
| /// <returns></returns> | |||
| [Obsolete(QuerySession.SynchronousRemoval)] | |||
| IReadOnlyList<T> Query<T>(string sql, params object[] parameters); | |||
There was a problem hiding this comment.
A couple of spots where the obsolete warning for synchronous db methods was missing.
|
There will be some small merge conflicts between this and #3604. Some of the wording in the documentation will need to change. There should be no issues with the code itself. |
|
failing tests are related to stronglyTypedIds and don't appear to be related to these code changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
char placeholderparam is always before thestring sqlparam. This is to ensure that the overload is backwards compatible.,Updated all methods that accept parameters except for:
MatchesJsonPath- This should probably be marked as obsolete as the placeholder overload does the same thing but better.Todo: