[oskardudycz]

Added tests for issue #1105

[mysticmind]

I believe the same can be applied as an attribute on the IEnumerable properties on the class to achieve the same rather than customizing the serializer at the store level. Thoughts?

[oskardudycz]

@mysticmind good catch, I'll add next case checking that

[robert-skarzycki]

@oskardudycz, what about one more level down, i.e. having creation of test data looking like this:

 public static TypeWithInnerCollections Create(params string[] array)
        {
            return new TypeWithInnerCollections()
            {
                Id = Guid.NewGuid(),
                Array = array,
                Flatten = array.Aggregate((i, j) => i + j),
                Enumerable = array.AsEnumerable(),
                IEnumerableFromArray = array,
                IEnumerbaleFromList = array.ToList(),
                List = array.ToList(),
                IList = array.ToList(),
                IReadonlyCollection = array.ToList(),
                IReadonlyCollectionOfInnerClasses = new List<TypeWithInnerCollections>
                    {
                        new TypeWithInnerCollections()
                        {
                            Id = Guid.NewGuid(),
                            Array = array,
                            Flatten = array.Aggregate((i, j) => i + j),
                            Enumerable = array.AsEnumerable(),
                            IEnumerableFromArray = array,
                            IEnumerbaleFromList = array.ToList(),
                            List = array.ToList(),
                            IList = array.ToList(),
                            IReadonlyCollection = array.ToList(),
                            IReadonlyCollectionOfInnerClasses = new List<TypeWithInnerCollections>
                            {
                                new TypeWithInnerCollections()
                                {
                                    Id = Guid.NewGuid(),
                                    Array = array,
                                    Flatten = array.Aggregate((i, j) => i + j),
                                    Enumerable = array.AsEnumerable(),
                                    IEnumerableFromArray = array,
                                    IEnumerbaleFromList = array.ToList(),
                                    List = array.ToList(),
                                    IList = array.ToList(),
                                    IReadonlyCollection = array.ToList(),
                                }
                            }
                        }
                    }
            };

?

Then having a query over this extra-level leaves would fail:

await query.Query<TypeWithInnerCollections>()
                .Where(x => x
                .IReadonlyCollectionOfInnerClasses
                .Any(y => y.IReadonlyCollectionOfInnerClasses
                .Where(e => e.Flatten == "onetwo")
                .Any())
                || x
                .IReadonlyCollectionOfInnerClasses
                .Any(y => y.IReadonlyCollectionOfInnerClasses
                .Where(e => e.Flatten == "twothree").Any())
                )
                .ToListAsync();

with exception stating that only Contains is allowed inside Any.

P.S. That's what I meant by asking about subqueries on Gitter: https://gitter.im/JasperFx/marten?at=5c66d8b64bafd97ca3f8f457

[oskardudycz]

@robert-skarzycki I agree, current support for InnerCollection queries is far from being ideal. I'll try to revisit that after I finish my work on NodaTime support. But the fix won't be quick, probably no sooner than in version 3.6...
For now as a workaround I would suggest to use getters with flattened strucures. It's workaround as this will make data denormalized but it should work for most of the cases.

[mysticmind]

@oskardudycz I have added CollectionToArrayJsonConverter<T> under Marten.Util and updated the unit tests to apply attribute [JsonConverter(typeof(Marten.Util.CollectionToArrayJsonConverter<TypeWithInnerCollections>))] on collection properties. All tests are green.

With this fix, we can close #1105 and #1192. We will also need to add some documentation on this.

[oskardudycz]

@mysticmind I made few additional improvements:

• Refactored CollectionToArrayJsonConverter to not need generic parameter,
• added JsonNetContractResolver to allow global setting of storing collections as arrays

Could you have a look and share your thoughts? 😄

[mysticmind]

@oskardudycz Looks like the tests are failing with the recent changes, can you please have a look?

[oskardudycz]

@mysticmind should be good now. Too long document class name ;)

[mysticmind]

@oskardudycz I have added few review comments. Please have a look.

[oskardudycz]

@mysticmind comments applied ;)

[mysticmind]

Looks good to me now.