Close any open connection if any command fails

[jeremydmiller]

Paranoid connection cleanup. session.Dispose() should clean things up by itself, but let's not count on users to do things right every time.

[mdissel]

So this means that after an exception you're session can't be used anymore? Properly disposing is in my opinion something an user should do..

[jeremydmiller]

If you're counting on users knowing what they're doing, sure. We can make this configurable later, but I'm rushing this one into a private build for our shop today.

[jeremydmiller]

We'll make this an opt-in behavior before 1.3 is released. It's going into a private 1.2.2 build this morning though.

[mdissel]

It's exactly the same as when they're using the IDbConnection or a FileStream or whatever IDiposable object.

[jeremydmiller]

@mdissel FFS, I'm very well aware of the design issues and I'm reacting to real production issues, not having a discussion about theory here.

[mdissel]

Yes, but this is breaking change, not catched by a full code coverage unit test.. for example:

try {
 ...
 session.Store(..);
} catch (Exception ex){
  Log log = new Log(..);
  session.Store(log);
}

will fail with this update.

[jeremydmiller]

See what I said about "opt in" behavior above.

[jeremydmiller]

@mdissel Actually, your example would work as is. The first connection would be slammed shut, but you'd be able to still use the session w/ a new transaction. Not sure it's really all that useful at that point though.

Store() by itself wouldn't make any database calls w/ the exception of needing to fetch a new Hilo data set.

[jeremydmiller]

Going to call this one closed for now. We'll open a separate issue later if this causes any harm.