Skip to content

Fix the race in SideEffectGateTimeoutTests.a_timeout_that_did_not_reach_the_prior_mark_pauses_the_shard #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremydmiller merged 1 commit into from
Aug 2, 2026
Merged

Fix the race in SideEffectGateTimeoutTests.a_timeout_that_did_not_reach_the_prior_mark_pauses_the_shard #609

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/EventTests/Daemon/SideEffectGateTimeoutTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,21 +62,26 @@ public async Task a_timeout_that_did_not_reach_the_prior_mark_pauses_the_shard()
// The genuine failure. Side effects must NOT be enabled over history the prior version already
// covered, so no continuous agent starts — but the shard is published as Paused rather than left
// silently stopped, so it is visible to a supervisor and resumes from its persisted floor.
var paused = new List<ShardState>();
// ShardStateTracker publishes through a Block<ShardState>, so an observer runs on the block's
// consumer thread and is NOT guaranteed to have run by the time StartAgentAsync returns.
// Collecting into a List and asserting straight after the call is a race, and CI lost it: the
// list was empty at the assertion and held the state by the time Shouldly rendered the failure
// message, which is why that failure read "should have single item but had 1 items".
var paused = new TaskCompletionSource<ShardState>(TaskCreationOptions.RunContinuationsAsynchronously);

await using var harness = new DaemonHarness(
settings => settings.SideEffectGateTimeout = 250.Milliseconds(),
progressReads: [0, PriorMark - 40],
onShardState: state =>
{
if (state.Action == ShardAction.Paused) paused.Add(state);
if (state.Action == ShardAction.Paused) paused.TrySetResult(state);
});

await harness.Daemon.StartAgentAsync("Trip:V2:All", CancellationToken.None);

harness.Daemon.CurrentAgents().ShouldNotContain(x => x.Name.Identity == "Trip:V2:All");

var state = paused.ShouldHaveSingleItem();
var state = await paused.Task.WaitAsync(TestTimeout);
state.ShardName.ShouldBe("Trip:V2:All");
state.Sequence.ShouldBe(PriorMark - 40);
state.PauseReason.ShouldContain("side-effect gate warm-up timed out");
Expand Down
Loading