fix(sourcegen): dedupe overridden required members in evolver constru…#429
Merged
Conversation
…ction
BuildAggregateConstructorExpression walked the inheritance chain and
collected every required member by name with no dedup, so an
`override required` (or `new`-shadowed required) property was added once
for the base declaration and once for the derived override. The emitted
object initializer then read
`new T { Prop = default!, Prop = default! }`, failing to compile with
CS1912 (duplicate member initialization) and breaking the whole consuming
assembly's build.
Dedupe by name with a HashSet; the walk runs most-derived -> base so the
first sighting wins.
Closes JasperFx#428
Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BuildAggregateConstructorExpression walked the inheritance chain and collected every required member by name with no dedup, so an
override required(ornew-shadowed required) property was added once for the base declaration and once for the derived override. The emitted object initializer then readnew T { Prop = default!, Prop = default! }, failing to compile with CS1912 (duplicate member initialization) and breaking the whole consuming assembly's build.Dedupe by name with a HashSet; the walk runs most-derived -> base so the first sighting wins.
Closes #428