Fix source-created codegen variable reuse#392
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #391.
This updates
MethodFrameArrangerso a variable source that returns a concrete variable for an interface request is reused later when the concrete type is requested. The arranger now considers already-known created variables and their sibling cast variables before asking the same source to create another frame.Root Cause
In the tenanted Wolverine.HTTP + Marten path, one frame can first request
IMessageBus/IMessageContext, causing the source to create a concreteMessageContextframe plus cast variables. Later the outboxed Marten session frame requests the concreteMessageContext. The arranger only looked at top-level method frames before invoking sources again, so it built a secondMessageContextframe and generated a duplicatevar messageContextdeclaration.Tests
dotnet test src\CodegenTests\CodegenTests.csproj --no-restore