Skip to content

Make JasperFx.Events.SourceGenerator flow transitively (drop DevelopmentDependency) #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremydmiller merged 1 commit into from
May 26, 2026
Merged

Make JasperFx.Events.SourceGenerator flow transitively (drop DevelopmentDependency) #368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/JasperFx.Events.SourceGenerator/JasperFx.Events.SourceGenerator.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,15 @@
<PackageId>JasperFx.Events.SourceGenerator</PackageId>
<Version>2.1.1</Version>
<IncludeBuildOutput>false</IncludeBuildOutput>
<DevelopmentDependency>true</DevelopmentDependency>
<!-- Deliberately NOT a DevelopmentDependency. This analyzer must flow transitively
from packages that reference it (notably Marten) to *their* consumers: Marten 9
removed the runtime evolver fallback, so any project defining projection types
needs this generator, including ones that only reference Marten. A
developmentDependency is consumed as PrivateAssets=all and never flows, which is
what left plain-Marten consumers without the generator (marten#4557). The package
is analyzer-only (IncludeBuildOutput=false, no lib/), so flowing it adds no runtime
assembly. Because it is a single package identity, a consumer that also references
it directly collapses to one analyzer path (no duplicate generation / CS0111). -->
</PropertyGroup>

<ItemGroup>
Expand Down
Loading