Fix source generator evolver and hint-name failures#359
Merged
jeremydmiller merged 2 commits intoMay 23, 2026
Merged
Conversation
Member
|
Verified this locally and it's the complete fix for marten#4542 (+ marten#4543). 👍
Two small things I'd double-check before merge (both look fine on read):
Happy to push my 3 construction-focused tests onto this branch if you'd like the extra coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
AddSource()so Roslyn-invalid characters such as?cannot crash generation.[ReadAggregate]aggregate parameters discovered viaIRefersToAggregateattributes.Why
Two source-generator paths could break Marten 9 upgrade scenarios:
[ReadAggregate] EigenPrestatie? prestatiecould feed?into generated hint names, causing Roslyn to rejectAddSource()and abort the whole generator pass.Addresses JasperFx/marten#4542 and JasperFx/marten#4543.
Validation
dotnet test .\src\JasperFx.Events.SourceGenerator.Tests\JasperFx.Events.SourceGenerator.Tests.csproj --no-restore