Fix DatabaseUri() for unix socket paths#170
Merged
jeremydmiller merged 1 commit intomainfrom Mar 25, 2026
Merged
Conversation
Sanitize server names containing forward slashes and colons (common in unix socket paths like /cloudsql/platform-dev:europe-west4:shared-db) by replacing them with underscores before constructing the URI. This prevents UriFormatException when the server name contains characters invalid in URI hostnames. Closes JasperFx/marten#4204 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This was referenced Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DatabaseDescriptor.DatabaseUri()by replacing/and:with_before URI construction/cloudsql/platform-dev:europe-west4:shared-db) contain characters invalid in URI hostnames, causingUriFormatExceptionCloses JasperFx/marten#4204
Test plan
/cloudsql/platform-dev:europe-west4:shared-db) produces valid URIhost1,host2,host3) uses first host🤖 Generated with Claude Code