Fix raised events going to every stream, plus IsValidNumber and ReadExpectedBufferAsync false positives

src/CoreTests/StreamExtensionsTests.cs

@@ -65,4 +65,87 @@ public async Task read_all_bytes_async()
 
         actual.ShouldBe(bytes);
     }
+
+    [Fact]
+    public async Task read_expected_buffer_matches_the_exact_bytes()
+    {
+        var stream = new MemoryStream([1, 2, 3]);
+
+        (await stream.ReadExpectedBufferAsync([1, 2, 3])).ShouldBeTrue();
+    }
+
+    [Fact]
+    public async Task read_expected_buffer_rejects_different_bytes()
+    {
+        var stream = new MemoryStream([1, 2, 4]);
+
+        (await stream.ReadExpectedBufferAsync([1, 2, 3])).ShouldBeFalse();
+    }
+
+    [Fact]
+    public async Task read_expected_buffer_only_consumes_what_it_expects()
+    {
+        var stream = new MemoryStream([1, 2, 3]);
+
+        (await stream.ReadExpectedBufferAsync([1, 2])).ShouldBeTrue();
+
+        stream.Position.ShouldBe(2);
+    }
+
+    [Fact]
+    public async Task read_expected_buffer_rejects_a_stream_that_ends_short_of_trailing_zeros()
+    {
+        var stream = new MemoryStream([1]);
+
+        (await stream.ReadExpectedBufferAsync([1, 0])).ShouldBeFalse();
+    }
+
+    [Fact]
+    public async Task read_expected_buffer_rejects_an_empty_stream_when_expecting_zeros()
+    {
+        var stream = new MemoryStream();
+
+        (await stream.ReadExpectedBufferAsync([0, 0])).ShouldBeFalse();
+    }
+
+    [Fact]
+    public async Task read_expected_buffer_keeps_reading_across_partial_reads()
+    {
+        var stream = new OneByteAtATimeStream([1, 2, 3]);
+
+        (await stream.ReadExpectedBufferAsync([1, 2, 3])).ShouldBeTrue();
+    }
+
+    [Fact]
+    public async Task read_bytes_keeps_reading_across_partial_reads()
+    {
+        var stream = new OneByteAtATimeStream([1, 2, 3]);
+
+        (await stream.ReadBytesAsync(3)).ShouldBe(new byte[] { 1, 2, 3 });
+    }
+
+    // Pinned, not endorsed. Wolverine's TCP listener reads its length prefix with this and treats all zeros
+    // as nothing to do, which is how it ignores a connection that closes without sending anything, like a
+    // TCP health probe. Throwing here would turn each of those into an error
+    [Fact]
+    public async Task read_bytes_leaves_the_rest_of_the_buffer_zeroed_on_a_short_read()
+    {
+        var stream = new MemoryStream([1]);
+
+        (await stream.ReadBytesAsync(3)).ShouldBe(new byte[] { 1, 0, 0 });
+    }
+
+    [Fact]
+    public async Task read_bytes_returns_zeros_from_an_empty_stream()
+    {
+        var stream = new MemoryStream();
+
+        (await stream.ReadBytesAsync(4)).ShouldBe(new byte[4]);
+    }
+
+    private class OneByteAtATimeStream(byte[] bytes) : MemoryStream(bytes)
+    {
+        public override ValueTask<int> ReadAsync(Memory<byte> buffer, CancellationToken cancellationToken = default)
+            => base.ReadAsync(buffer[..Math.Min(1, buffer.Length)], cancellationToken);
+    }
 }

src/CoreTests/StringExtensionsTester.cs

@@ -132,6 +132,55 @@ public void numbers_should_be_invalid()
         foreach (var number in numbers) number.IsValidNumber(new CultureInfo("en-us")).ShouldBeFalse();
     }
 
+    [Theory]
+    [InlineData("1x234")]
+    [InlineData("1 234")]
+    [InlineData("12x345x678")]
+    public void the_group_separator_is_not_a_wildcard(string number)
+    {
+        // The de-DE group separator is "."
+        number.IsValidNumber(new CultureInfo("de-DE")).ShouldBeFalse();
+    }
+
+    [Theory]
+    [InlineData("")]
+    [InlineData("-")]
+    public void a_number_has_to_have_a_digit(string number)
+    {
+        number.IsValidNumber(new CultureInfo("en-us")).ShouldBeFalse();
+    }
+
+    [Theory]
+    [InlineData("123\n")]
+    [InlineData("1,000.1\n")]
+    public void nothing_may_follow_the_number(string number)
+    {
+        number.IsValidNumber(new CultureInfo("en-us")).ShouldBeFalse();
+    }
+
+    [Theory]
+    [InlineData("0")]
+    [InlineData("-1")]
+    [InlineData(".5")]
+    [InlineData("-.5")]
+    [InlineData("-1,000.5")]
+    public void numbers_that_stay_valid(string number)
+    {
+        number.IsValidNumber(new CultureInfo("en-us")).ShouldBeTrue();
+    }
+
+    [Fact]
+    public void every_culture_accepts_a_number_written_with_its_own_separators()
+    {
+        foreach (var culture in CultureInfo.GetCultures(CultureTypes.AllCultures))
+        {
+            var format = culture.NumberFormat;
+            var number = $"1{format.NumberGroupSeparator}234{format.NumberDecimalSeparator}5";
+
+            number.IsValidNumber(culture).ShouldBeTrue(culture.Name);
+        }
+    }
+
     [Fact]
     public void to_bool()
     {