Remove redundant type constraint T: class on IUrlEpxression.Json method #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Sorry I completely forgot about this, will get this in. |
This was referenced Jul 28, 2025
peggy-quartech
pushed a commit
to bcgov/PSSG-SPDBT
that referenced
this pull request
Aug 25, 2025
Updated [Alba](git://github.com/JasperFx/alba) from 8.2.0 to 8.2.1. <details> <summary>Release notes</summary> _Sourced from [Alba's releases](git://github.com/JasperFx/alba/releases)._ ## 8.2.1 ## Bug Fixes * Remove redundant type constraint T: class on IUrlEpxression.Json method by @thuijer in JasperFx/alba#200 ## Internal Changes * Fix some documentation typos by @Hawxy in JasperFx/alba#187 * exclude *.received.* since they are a temp file used by Verify by @SimonCropp in JasperFx/alba#188 * Simplify snapshot testing by @SimonCropp in JasperFx/alba#189 * add link to Verify.AspNetCore by @SimonCropp in JasperFx/alba#190 * use well known header properties by @SimonCropp in JasperFx/alba#191 * cleanup HttpRequestBody by @SimonCropp in JasperFx/alba#193 * make Snapshot Testing reflect recent verify changes by @SimonCropp in JasperFx/alba#192 * avoid redundant stream to array allocation in AssertionContext by @SimonCropp in JasperFx/alba#194 * avoid multiple calls to enumerable.Count in ShouldHaveTheSameElementKeysAs by @SimonCropp in JasperFx/alba#195 * avoid duplicate dictionary lookup in NoHeaderValueAssertion by @SimonCropp in JasperFx/alba#196 ## New Contributors * @thuijer made their first contribution in JasperFx/alba#200 **Full Changelog**: JasperFx/alba@v8.2.0...v8.2.1 Commits viewable in [compare view](git://github.com/JasperFx/alba/compare/v8.2.0...v8.2.1). </details> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type constraint "where T: class" on IUrlEpxression.Json makes it impossible to use structs in test scenarios. Given that structs are serializable by default, I don't see the benefit of having this constraint in place.