Skip to content

avoid duplicate dictionary lookup in NoHeaderValueAssertion #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

avoid duplicate dictionary lookup in NoHeaderValueAssertion #196

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Alba/Assertions/NoHeaderValueAssertion.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,8 @@ public NoHeaderValueAssertion(string headerKey)
public void Assert(Scenario scenario, AssertionContext context)
{
var headers = context.HttpContext.Response.Headers;
if (headers.ContainsKey(_headerKey))
if (headers.TryGetValue(_headerKey, out var values))
{
var values = headers[_headerKey];
var valueText = values.Select(x => "'" + x + "'").Aggregate((s1, s2) => $"{s1}, {s2}");
context.AddFailure($"Expected no value for header '{_headerKey}', but found values {valueText}");
}
Expand Down
Loading