DB reader update, API throttling #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed binary writing int Enums that stored as byte Added DbBeatmapStatuses, removed unused status Renamed unknown properties Throwing NotImplementedException in not implemented WriteValue method
Added constructors for configuring each API repository instance individually Added docs to IApiScoreRepository Removed nested API repositories
Added files to .NET Framework project Minor compatibility change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
The main goal of this PR is to fix *.db file reader, now it can read files with version
20191106and later.Unknown properties like
SomeBool,Byte,Byte2, etc renamed,DbBeatmapStatusenum entries slightly changed, added enum for UserPersmissons, all this according to osu wiki.Regular Int32 Enums now can be saved as Bytes, unfornunately your commit mentioned here did not fixed this.
NotImplementedExceptionadded because i tried read-write toosu!.dband this always results in file with less data than i just read, turns outWriteValuefor binary dictionaries is just empty. Absense of exceptions or at least console message here was very confusing.API repositories now can be throttled. In practice it seems to be not needed today, but i already implemented this. Maybe would be usefull in multithreading.