Add quotes around title in search query #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without quotes, some queries find more than 100 results, but only the first 100 are returned. This can lead to matching issues titles not being found even when they exist.
This will prevent quotes from conflicting if they are present in the issue title being used in the query.
JasonEtco
approved these changes
Dec 13, 2022
There was a problem hiding this comment.
Thanks for the fix @parkerbxyz 🙇 I added a test and snuck in a CI version upgrade.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without quotes, some queries find more than 100 results, but only the first 100 are returned. This can lead to matching issues titles not being found even when they exist.
Any quotes present in the issue title included in the query will be escaped to avoid conflicting quotes.