Fix bug in SXP bit_input_stream leading to incorrect Impulse Tracker conversion #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the
bit_input_streamtype in the bundled SXP library, which is used by theconvert_it()function in the pmf_converter tool.When refilling the internal cache buffer in
bit_input_stream, them_cache_start_bit_posvariable is always moved forward by a full buffer size, even when fewer bytes than that have been read from the stream. This leads to thebit_input_streamreporting end-of-stream much earlier than intended, which cuts the sample short.This PR fixes issue #9. After application of this PR, the full voice sample can be heard.