Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing commas from yaml config #58

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rpuch
Copy link

@rpuch rpuch commented Mar 30, 2021

Actually, I'm not 100% sure that this is the correct fix to do as, according to git annotate, these lines are 3 years old, but with JanusGraph-0.5.2 I get the following error when starting the server:

74   [main] ERROR org.apache.tinkerpop.gremlin.server.GremlinServer  - Configuration file at conf/gremlin-server/gremlin-server.yaml could not be found or parsed properly. [while parsing a block mapping; expected <block end>, but found FlowEntry;  in 'reader', line 44, column 54:
     ... nabled: false, interval: 180000},                                         ^]

Removal of the trailing commas resolved the issue for me.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 30, 2021

CLA Signed

The committers are authorized under a signed CLA.

@janusgraph-bot janusgraph-bot added the cla: external Externally-managed CLA label Mar 30, 2021
@rngcntr
Copy link
Contributor

rngcntr commented Mar 31, 2021

Hi @rpuch, thanks for your contribution!
Could you please redo your commit with git commit --amend --no-edit --signoff so that the DCO check passes?

Because this breaks parsing

Signed-off-by: Roman Puchkovskiy <[email protected]>
@rpuch rpuch force-pushed the remove-trailing-commas-from-yaml-config branch from e8f2e07 to f26df2d Compare March 31, 2021 08:28
@rpuch
Copy link
Author

rpuch commented Mar 31, 2021

Hi @rpuch, thanks for your contribution!
Could you please redo your commit with git commit --amend --no-edit --signoff so that the DCO check passes?

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: external Externally-managed CLA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants