Fix chained item function empty result comparison in conditions

[Copilot]

Context

Chained item functions incorrectly evaluate as non-empty in conditions when the final result is empty. For example:

<ItemGroup>
  <TestItem Include="Test1" Foo="Bar" />
</ItemGroup>

<!-- This condition should be true (result is empty) but evaluates to false -->
<Message Text="Success" 
  Condition="'@(TestItem->WithMetadataValue('Identity','Test1')->WithMetadataValue('Foo','Baz'))' == ''" />

The first transform matches Test1, but the second filters it out (Foo='Bar' != 'Baz'). The final result is empty, yet the condition fails.

Changes Made

src/Build/Evaluation/Expander.cs

• Moved BreakOnNotEmpty check in Transform method to execute after all chained transforms complete, not after each intermediate transform
• Previously checked after each transform at line ~2024, causing early bailout on intermediate non-empty results
• Now checks only the final result at line ~2032-2043

src/Build.UnitTests/Evaluation/Expander_Tests.cs

• Added ChainedItemFunctionEmptyResultInCondition test verifying the fix

Testing

Unit test added to validate the specific scenario. Full test suite and manual verification pending.

Notes

The bug only manifested when using BreakOnNotEmpty optimization (condition evaluation path), not in normal property expansion.

Original prompt

---

This section details on the original issue you should resolve

<issue_title>When chaining item functions and comparing the result to empty string, the comparison will return false incorrectly.</issue_title>
<issue_description>### Issue Description

Given the items:

    <ItemGroup>
      <TestItem Include="Test1" Foo="Bar" />
      <TestItem Include="Test2" />
    </ItemGroup>

And the comparison:

<Message Text="Don't have Test1/@Foo=Baz" Condition="'@(TestItem->WithMetadataValue('Identity', 'Test1')->WithMetadataValue('Foo', 'Baz'))' == ''" Importance="high" />

I would expect the condition to be true, but it is false. Emitting the result of the item function does show that it is an empty string.

Steps to Reproduce

Create a project, add the following.

  <Target Name="TestItem">

    <ItemGroup>
      <TestItem Include="Test1" Foo="Bar" />
      <TestItem Include="Test2" />
    </ItemGroup>

    <Message Text="@(TestItem->WithMetadataValue('Identity', 'Test1'))" Importance="high" />
    <Message Text="Have Test1" Condition="'@(TestItem->WithMetadataValue('Identity', 'Test1'))' != ''" Importance="high" />
    <Message Text="Don't have Test3" Condition="'@(TestItem->WithMetadataValue('Identity', 'Test3'))' == ''" Importance="high" />
    <Message Text="Have Test1/@Foo=Bar" Condition="'@(TestItem->WithMetadataValue('Identity', 'Test1')->WithMetadataValue('Foo', 'Bar'))' != ''" Importance="high" />
    <Message Text="Don't have Test1/@Foo=Baz" Condition="'@(TestItem->WithMetadataValue('Identity', 'Test1')->WithMetadataValue('Foo', 'Baz'))' == ''" Importance="high" />

  </Target>

build with dotnet msbuild /t:TestItem /tl:off

Expected Behavior

Emits:

  Test1
  Have Test1
  Don't have Test3
  Have Test1/@Foo=Bar
  Don't have Test1/@Foo=Baz

Actual Behavior

Emits:

  Test1
  Have Test1
  Don't have Test3
  Have Test1/@Foo=Bar

Analysis

No response

Versions & Configurations

MSBuild version 18.0.2+b0f34d51f for .NET</issue_description>

<agent_instructions>Investigate if this is reasonable and provide a fix if yes.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

• Fixes When chaining item functions and comparing the result to empty string, the comparison will return false incorrectly. dotnet/msbuild#12877

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.