This repository has been archived by the owner on Mar 9, 2020. It is now read-only.
Fix sheet reference in ToR1C1 formula translation #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttests for .net core
…or addresses, available via ParsingContext. ExcelRanges are now always compiled in ExcelAddressExpression, the SkipArgumentEvaluation parameter is removed, and addresses can be accessed via cache references
# Conflicts: # EPPlusTest/ExcelCellBaseTests.cs
If an ExcelAddress token satisfies the following conditions: - contains a worksheet name (followed by "!") - contains a reference to a single row or column (so it will also have a ":") then the worksheet name is not returned when the address is translated from A1-style to R1C1-style. This is now fixed. Closes #479
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an ExcelAddress token satisfies the following conditions:
then the worksheet name is not returned when the address is translated from A1-style to R1C1-style.
This is now fixed. Closes #479