Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambient and Directional light updates #53

Merged
merged 10 commits into from
May 27, 2022
Merged

Conversation

JamesTKhan
Copy link
Owner

Support for only one Directional Light was left the same. I considered supporting multiple but don't see the value in it at this point in time. Could be expanded on later if multiple direction lights is really needed.

  • Enable and fix ambient light dialog
  • New dialog for directional light and new properties that save directional light settings in the Scene file.
  • Update water shader to include directional light and ambient light
2022-05-26.00-21-51.mp4

@JamesTKhan JamesTKhan linked an issue May 26, 2022 that may be closed by this pull request
…_lights

# Conflicts:
#	commons/src/main/com/mbrlabs/mundus/commons/dto/SceneDTO.java
#	gdx-runtime/CHANGES
@Dgzt
Copy link
Collaborator

Dgzt commented May 26, 2022

I get this exception on linux:

Caused by: com.badlogic.gdx.utils.GdxRuntimeException: Fragment shader:
0:102(2): error: initializer of type vec4 cannot be assigned to variable of type vec3

	at com.mbrlabs.mundus.commons.utils.ShaderUtils.compile(ShaderUtils.java:54)
	at com.mbrlabs.mundus.commons.shaders.WaterShader.<init>(WaterShader.java:70)
	at com.mbrlabs.mundus.editor.shader.Shaders.<clinit>(Shaders.kt:49)
	... 12 more

[09:12][Fatal][Log] Uncaught exception occurred, error report will be saved

@JamesTKhan
Copy link
Owner Author

I get this exception on linux:

Caused by: com.badlogic.gdx.utils.GdxRuntimeException: Fragment shader:
0:102(2): error: initializer of type vec4 cannot be assigned to variable of type vec3

	at com.mbrlabs.mundus.commons.utils.ShaderUtils.compile(ShaderUtils.java:54)
	at com.mbrlabs.mundus.commons.shaders.WaterShader.<init>(WaterShader.java:70)
	at com.mbrlabs.mundus.editor.shader.Shaders.<clinit>(Shaders.kt:49)
	... 12 more

[09:12][Fatal][Log] Uncaught exception occurred, error report will be saved

@Dgzt Good catch this should be fixed now.

@JamesTKhan JamesTKhan merged commit ec12382 into master May 27, 2022
@JamesTKhan JamesTKhan deleted the ambient_directional_lights branch May 27, 2022 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add UI for Ambient and Directional Light
2 participants