Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored runtime's Mundus #42

Merged
merged 1 commit into from
May 20, 2022
Merged

Refactored runtime's Mundus #42

merged 1 commit into from
May 20, 2022

Conversation

Dgzt
Copy link
Collaborator

@Dgzt Dgzt commented May 19, 2022

A bit refactor.

I think with this changes who uses this runtime will have less chance of making mistakes.

Currently:

batch = new ModelBatch();

mundus = new Mundus(Gdx.files.internal("mundus"));
mundis.init();
scene = mundus.loadScene("Main Scene.mundus");
scene.batch = batch;

The developer can leave init method, or forget to set batch and these will generate exception.

With changes this is enough:

batch = new ModelBatch();

mundus = new Mundus(Gdx.files.internal("mundus"));
scene = mundus.loadScene("Main Scene.mundus", batch);

@JamesTKhan JamesTKhan merged commit e28535e into master May 20, 2022
@JamesTKhan JamesTKhan deleted the runtime-mundus-refactor branch May 20, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants