Removal of new assets that are not saved #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dgzt
approved these changes
May 18, 2022
# Conflicts: # editor/src/main/com/mbrlabs/mundus/editor/assets/EditorAssetManager.kt # editor/src/main/com/mbrlabs/mundus/editor/ui/widgets/WaterWidget.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes behavior for when a new terrain or water component is created. Instead of saving them on creation they are added to a newAssets lists. To improve clarity, dirtyAssets was renamed to modifiedAssets.
Behaviors:
If the project is saved then they will be saved.
If the project is exited correctly, they will not be saved in the scene and their asset files and meta files will be deleted.
If the project is switched to another project, they will not be saved in the scene and their asset files and meta files will be deleted.
If the application crashes while they are not saved, they will not be saved in the scene but the asset files will remain and have to be removed manually.