-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Foam to Waters edges and Water refactoring #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # commons/src/main/com/mbrlabs/mundus/commons/scene3d/SceneGraph.java
JamesTKhan
changed the title
Add Foam to Waters edges and Water refactoring
(DRAFT) Add Foam to Waters edges and Water refactoring
May 17, 2022
JamesTKhan
changed the title
(DRAFT) Add Foam to Waters edges and Water refactoring
Add Foam to Waters edges and Water refactoring
May 17, 2022
Dgzt
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a basic water foam effect to water edges. This may be expanded on in the future but should work well if/when some kind of wave/mesh deformation is implemented.
Foam effect adapted from http://fire-face.com/personal/water/. Since we do not currently have wave deformations the foam scrolls by offset UVs instead. This means the foam only scrolls in one direction currently but hoping to improve on this later.
Untitled.2.mp4
.