Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skybox enhancements #33

Merged
merged 5 commits into from
May 11, 2022
Merged

Skybox enhancements #33

merged 5 commits into from
May 11, 2022

Conversation

JamesTKhan
Copy link
Owner

@JamesTKhan JamesTKhan commented May 11, 2022 •
edited
Loading

Overhaul of skyboxes, to complete the feature.

  • Revamp some of the skybox dialog UI, including basic validations on skybox name and image fields
  • Skyboxes now create and save
  • We now have a SkyboxAsset file (.sky) which stores the TextureAsset ids for the skybox
  • Skybox textures are imported to project on skybox creation
  • Different scenes can have different skyboxes
  • Skyboxes can be reused between scenes now that they are an asset
  • On new project creation a default skybox is created
  • For existing projects, you will need to open the UI and set the default skybox
skyboxes.mp4

@Dgzt
Copy link
Collaborator

Dgzt commented May 11, 2022

Looks very good. :)

@JamesTKhan JamesTKhan merged commit 11c979d into master May 11, 2022
@JamesTKhan JamesTKhan deleted the skybox-enhancements branch May 11, 2022 11:55
@JamesTKhan JamesTKhan linked an issue May 11, 2022 that may be closed by this pull request
Skybox issues #25
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dgzt Dgzt Dgzt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skybox issues
2 participants
@JamesTKhan @Dgzt