Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ready: Add asset deletion within UI #2

Merged
merged 13 commits into from
Apr 20, 2022
Merged

Ready: Add asset deletion within UI #2

merged 13 commits into from
Apr 20, 2022

Conversation

JamesTKhan
Copy link
Owner

@JamesTKhan JamesTKhan commented Feb 16, 2022 •
edited
Loading

PR for implementing Asset Deletion within Mundus UI.

Done:

  • Actual deletion of gltf bin, meta, and asset file
  • Add asset usage interface
  • add dialog that displays all usages of an asset upon deletion
  • add fallback code to recover from an NPE in the event of a missing asset/component
2022-04-19.14-27-17.mp4

@Dgzt
Copy link
Collaborator

Dgzt commented Apr 15, 2022 •
edited
Loading

I think the Option 1 is more user friendly than Option 2.

@JamesTKhan JamesTKhan marked this pull request as ready for review April 19, 2022 18:47
@JamesTKhan JamesTKhan changed the title Add asset deletion within UI Ready: Add asset deletion within UI Apr 19, 2022
@Dgzt
Copy link
Collaborator

Dgzt commented Apr 19, 2022

Looks good :)

@JamesTKhan
Merge branch 'master' into asset_deletion
fa9faf7 
# Conflicts:
#	commons/src/main/com/mbrlabs/mundus/commons/assets/TerrainAsset.java
#	commons/src/main/com/mbrlabs/mundus/commons/scene3d/components/TerrainComponent.java
@JamesTKhan JamesTKhan merged commit fca9077 into master Apr 20, 2022
@JamesTKhan JamesTKhan deleted the asset_deletion branch May 10, 2022 03:29
@antzGames antzGames mentioned this pull request May 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamesTKhan @Dgzt