Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on a feature branch, I noticed a frame drop when posting evens often. I looked into the EventBus code for the first time and saw some areas for improvement. Every time an event was posted the EventBus searched through every subscriber, check that it is a subscriber, and then find and call the event method all of this using reflection was quite slow.
Updated the EventBus class to perform the reflection logic on Register instead, and then cache Event class -> Subscriber in a map for fast lookup on Post so now we only perform the slow operations once on register. Also cleaned up the class a bit and added more code documentation to the methods.
Additionally, added a junit test for the EventBus.
In a quick performance test of posting 100 events with 100 subscribers, the old code took 22ms, the new code took 2ms.