GL30: Use MRT FBO for Water refractions on gl30 #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dgzt
reviewed
Jun 8, 2023
| @@ -158,7 +163,7 @@ public void render(float delta) { | |||
| modelCacheManager.update(delta); | |||
|
|
|||
| if (sceneGraph.isContainsWater()) { | |||
| captureDepth(delta); | |||
| if (Gdx.gl30 == null) captureDepth(delta); | |||
There was a problem hiding this comment.
Minor thing: You can use Gdx.graphics.isGL30Available(). Maybe this is a bit more elegant then a null check.
There was a problem hiding this comment.
Yeah, it does the exact same thing (checks if gl30 is null) but its alot more verbose. I guess the readability is better though
There was a problem hiding this comment.
Ok, made the change. I also changed it so that Scene uses Nestable FBOs as well. When I originally added these in, I only needed them on the EditorScene due to editor using FBOs too. But, for those wanting to do post processing at runtime, we should use NestableFrameBuffer on Scene as well and now don't have to update FBO code in two places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first GL30 addition to Mundus. If GL30 is enabled/available, water refraction FBO uses MRT to attach a depth texture. This removes the need for an additional depth render pass for water refractions meaning less vertices, draw calls, and shader switches per frame.
GL20 behavior remains the same.