Add editable uv scale for terrains #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dgzt
reviewed
Apr 19, 2022
| @@ -57,6 +57,7 @@ private void parseTerrain(Meta meta, JsonValue jsonTerrain) { | |||
|
|
|||
| final MetaTerrain terrain = new MetaTerrain(); | |||
| terrain.setSize(jsonTerrain.getInt(MetaTerrain.JSON_SIZE)); | |||
| terrain.setUv(jsonTerrain.getFloat(MetaTerrain.JSON_UV_SCALE, 60)); | |||
There was a problem hiding this comment.
I think the value 60 would be better in a constant file as a constant and you can use it in every place. What do you think?
There was a problem hiding this comment.
hmm yeah, could use it there and in the uv vector initialization, trying to think if mundus already has a constants file
There was a problem hiding this comment.
Could put is as a public static in Terrain class actually. It already has some other default values there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add UV scale slider in the terrain settings tab that persists and is stored in MetaTerrain
2022-04-19.16-22-35_Trim.mp4