Tool and game object selection bugfixes #160

Dgzt · 2023-04-27T07:52:13Z

1) Clearing selection

Currently if select a game object and press ESC key then the selection is clearing but the game object is selected in the Outline and see it's properties on Inspector. And if change a property in Inspector then it doesn't change on game object.

Before fix:

After fix:

2) Selecting a brush tool

If selected a brush tool on terrain then the previous tool still selected on the toolbar, but not this tool the active. It's misleading. After fix, the previous selected tool (any tool from toolbar, like translate tool, rotate tool, etc) will be deselected.

Before fix:

After fix:

3) Going back from brush tool with ESC key

Currently If selected a terrain brush tool and pressing ESC key then brush tool will be deactivated but the previous tool on toolbar still visible as active but it doesn't active, the wireframe doesn't visible. After fix after pressing ESC key then the translate tool will be active and visible as active. And if press again ESC, then clear selection, see at 1).

Before fix:

After fix:

4) Selecting tool from toolbar while in brush tool

Currently if selecting a tool from toolbar while we are using a brush tool then the tool on toolbar will be visible as active but it doesn't active, the wireframe doesn't visible.

Before fix:

After fix:

5) Selecting asset while a tool was selected from toolbar

Currently if selecting an asset from assert dockbar while a tool was selected on a game object then the Outline still shows the previously selected game object and the wireframe still visible but the Inspector shows the asset''s data.

Before fix:

After fix:

6) Selecting asset while a terrain brush tool was selected

Currently if selecting an asset while a brush tool was selected then the brush tool still active.

Before fix:

After fix:

7) Editing position/rotation/scale while a terrain brush tool was selected

Currently if editing position or rotation or scale while a terrain brush tool was selected then nothing happens. After fix the whole transformation widget will be disabled if a brush tool was selected.

Before fix:

After fix:

8) Changing tab on terrain component widget after selected a brush tool

Currently if selected brush tool on a tab on terrain component widget and changing tab the selected tool still active and you don't see what tool active at the moment. After fix if changing tab on terrain component widget then the active tool will be the default translate tool.

Before fix:

After fix:

9) Editing name/visibility/tag while a terrain brush tool was selected

Similar to 7). Currently if editing name, visibility or tag in identifier widget while a terrain brush tool was selected then nothing happens. After fix the whole identifier widget will be disabled if a brush tool was selected.

Before fix:

After fix:

10) Missing highlight for selected texture on paint tab.

Currently if want to paint on a terrain the currently selected texture is not highlighted. After fix at paint tab open the first texture will be selected and highlighted and if select a texture it will be highlighted.

Before fix:

After fix:

…ted tool on UI.

Dgzt · 2023-04-27T14:56:26Z

@JamesTKhan @antzGames (and anyone else) What do you think these changes? Do you know any other scenario with tools?

antzGames · 2023-04-28T01:08:14Z

@Dgzt

I like these changes a lot.
You covered the annoying ones for sure. I cannot think of any others right now.

I can test your branch maybe this weekend.

Dgzt · 2023-04-28T19:47:39Z

I've found that if editing position or rotation or scale while a terrain brush tool was selected then nothing happens. Added as 7). The fix is missing yet.

antzGames · 2023-04-29T04:58:51Z

Did some testing. Here are my results and comments:

Clearing selection - works great. OK
Selecting a brush tool - I am confused what is the difference between the 2 videos (before/after)
Going back from brush tool with ESC key - works great. Love the double ESC (links to 1) brings you back to nothing selected.
Selecting tool from toolbar while in brush tool - OK
Selecting asset while a tool was selected from toolbar - OK - Yes this needed to be fixed.
Selecting asset while a terrain brush tool was selected - OK - Yes this needed to be fixed.
waiting for fix

I think Up/Down > Flatten > Smooth tab TOOLS should all be in one TAB (something like below pic).

The reason is that you will absolutely know which tool (up/down or flatten or smooth) is selected because its highlighted. Right now you need look at all the tabs to see what is selected. I know this is more work. Just wanted to let you know my opinion.

What is the benefit of having these 3 tools on separate tabs?

Dgzt · 2023-04-29T20:25:02Z

@antzGames Thank you that tested changes and wrote comment.

2. Selecting a brush tool - I am confused what is the difference between the 2 videos (before/after)

After selecting a brush tool the previous selected tool on toolbar (like translate tool, scale tool, etc) still visible as active. After fix the previous tool will be deselected. I've updated the description.

I think Up/Down > Flatten > Smooth tab TOOLS should all be in one TAB (something like below pic).

The reason is that you will absolutely know which tool (up/down or flatten or smooth) is selected because its highlighted. Right now you need look at all the tabs to see what is selected. I know this is more work. Just wanted to let you know my opinion.

What is the benefit of having these 3 tools on separate tabs?

Thank you that found this issue, I will ad to the list. I think it is better if all brush tools are on separate tab, because each brush tool has different tip and later can be more options. What do you think if change tab on Terrain Component widget then applications clears brush tool selection and selects translate tool on toolbar. Like if you press ESC button, in 3). Like this:

It is very easy to implement.

Dgzt · 2023-04-29T20:33:50Z

... I will ad to the list. ...

I've added as 8).

antzGames · 2023-04-29T21:39:18Z

Thank you that found this issue, I will ad to the list. I think it is better if all brush tools are on separate tab, because each brush tool has different tip and later can be more options. **What do you think if change tab on Terrain Component widget then applications clears brush tool selection and selects translate tool on toolbar. Like if you press ESC button, in 3).**

Yes this will work too.

Dgzt · 2023-04-30T11:53:46Z

I've found that if editing any field in identifier widget while a terrain brush tool is selected then nothing happens. Added as 9).

Dgzt · 2023-04-30T12:30:09Z

I've found the highlight for selected texture is missing on paint tab. Added as 10).

Dgzt · 2023-04-30T20:00:35Z

I've fixed all issues what I've found. If you test this PR and find an issue related this please let write a comment.

antzGames · 2023-05-01T01:02:26Z

So the selected texture on paint is the green highlight. Can we just have a green box around it? or a green check mark? You cannot see the selected texture's color. At first I thought it was a bug. But once I clicked on another texture to paint I saw what you were doing. Still testing.

antzGames · 2023-05-01T01:11:23Z

Editing position/rotation/scale while a terrain brush tool was selected: OK
Changing tab on terrain component widget after selected a brush tool: OK
Editing name/visibility/tag while a terrain brush tool was selected: OK
Missing highlight for selected texture on paint tab.: OK but see my comment in previous post.

Dgzt · 2023-05-01T05:04:53Z

So the selected texture on paint is the green highlight. Can we just have a green box around it? or a green check mark? You cannot see the selected texture's color. At first I thought it was a bug. But once I clicked on another texture to paint I saw what you were doing.

I've changed to this:

Yes, you are right. It's better.

I've updated video.

JamesTKhan · 2023-05-03T15:57:37Z

This looks awesome! Thanks for tracking down all these annoying little bugs. I have encountered them but never sat down and tried to list them all out.

I noticed one interesting thing, I didn't even realize SceneGraph had a selected variable for GameObject. That seems weird since EditorScene already tracks that. I see that you are updating the value

projectManager.current().currScene.currentSelection = selectedGameObject
projectManager.current().currScene.sceneGraph.selected = selectedGameObject

As far as I can tell looking through the code sceneGraph.selected is not used anywhere (except being set, but never is read/used) at all. Might be some old left over code. I think we can remove private GameObject selected; and its getters and setters from Scenegraph entirely.

If you can remove it, go ahead, otherwise remove your code that is setting sceneGraph.selected and I will remove the variable later.

…ject-selection-bugfixes # Conflicts: # editor/CHANGES

Dgzt · 2023-05-03T18:37:31Z

This looks awesome! Thanks for tracking down all these annoying little bugs. I have encountered them but never sat down and tried to list them all out.

I noticed one interesting thing, I didn't even realize SceneGraph had a selected variable for GameObject. That seems weird since EditorScene already tracks that. I see that you are updating the value
projectManager.current().currScene.currentSelection = selectedGameObject
projectManager.current().currScene.sceneGraph.selected = selectedGameObject
As far as I can tell looking through the code sceneGraph.selected is not used anywhere (except being set, but never is read/used) at all. Might be some old left over code. I think we can remove private GameObject selected; and its getters and setters from Scenegraph entirely.

If you can remove it, go ahead, otherwise remove your code that is setting sceneGraph.selected and I will remove the variable later.

Good catch. I removed this field.

Dgzt added 4 commits April 27, 2023 07:50

Clean outline and inspector after press ESC key. Highlight only selec…

e183a96

…ted tool on UI.

Clean Outline selection and wireframe after asset selecting

44e26c6

Clean asset dock if select game object

cd8cbae

Cleanup

0a30ca1

Dgzt marked this pull request as ready for review April 27, 2023 14:54

Dgzt added the bug Something isn't working label Apr 27, 2023

Dgzt marked this pull request as draft April 28, 2023 19:56

Merge branch 'master' into tool-and-gameobject-selection-bugfixes

18671ee

Dgzt added 3 commits April 30, 2023 07:13

Disable transform widget if a brush tool is selected

055cf3b

Set active tool to default translate tool if changing tab

387e418

Fix NPE if adding component while selected brush tool

42f58b4

Dgzt added 2 commits April 30, 2023 11:55

Disable inspector widget if a brush tool is selected

2dff85a

Disable only identifier widget instead of whole inspector

49512df

Highlight selected texture on paint tab

8ca847e

Dgzt marked this pull request as ready for review April 30, 2023 19:59

Update CHANGES

c6ca5d3

Highlight box around selected texture

c95248e

Dgzt added 2 commits May 3, 2023 18:30

Merge remote-tracking branch 'jamestkhan/master' into tool-and-gameob…

8a5a438

…ject-selection-bugfixes # Conflicts: # editor/CHANGES

Remove selected game object field in scene graph

579134d

Update CHANGES

baee4b4

JamesTKhan merged commit 2fda251 into JamesTKhan:master May 6, 2023

Dgzt deleted the tool-and-gameobject-selection-bugfixes branch May 9, 2023 05:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tool and game object selection bugfixes #160

Tool and game object selection bugfixes #160

Dgzt commented Apr 27, 2023 •

edited

Loading

Dgzt commented Apr 27, 2023

antzGames commented Apr 28, 2023

Dgzt commented Apr 28, 2023

antzGames commented Apr 29, 2023

Dgzt commented Apr 29, 2023

Dgzt commented Apr 29, 2023

antzGames commented Apr 29, 2023

Dgzt commented Apr 30, 2023 •

edited

Loading

Dgzt commented Apr 30, 2023

Dgzt commented Apr 30, 2023 •

edited

Loading

antzGames commented May 1, 2023 •

edited

Loading

antzGames commented May 1, 2023

Dgzt commented May 1, 2023

JamesTKhan commented May 3, 2023 •

edited

Loading

Dgzt commented May 3, 2023

Tool and game object selection bugfixes #160

Tool and game object selection bugfixes #160

Conversation

Dgzt commented Apr 27, 2023 • edited Loading

1) Clearing selection

2) Selecting a brush tool

3) Going back from brush tool with ESC key

4) Selecting tool from toolbar while in brush tool

5) Selecting asset while a tool was selected from toolbar

6) Selecting asset while a terrain brush tool was selected

7) Editing position/rotation/scale while a terrain brush tool was selected

8) Changing tab on terrain component widget after selected a brush tool

9) Editing name/visibility/tag while a terrain brush tool was selected

10) Missing highlight for selected texture on paint tab.

Dgzt commented Apr 27, 2023

antzGames commented Apr 28, 2023

Dgzt commented Apr 28, 2023

antzGames commented Apr 29, 2023

Dgzt commented Apr 29, 2023

Dgzt commented Apr 29, 2023

antzGames commented Apr 29, 2023

Dgzt commented Apr 30, 2023 • edited Loading

Dgzt commented Apr 30, 2023

Dgzt commented Apr 30, 2023 • edited Loading

antzGames commented May 1, 2023 • edited Loading

antzGames commented May 1, 2023

Dgzt commented May 1, 2023

JamesTKhan commented May 3, 2023 • edited Loading

Dgzt commented May 3, 2023

Dgzt commented Apr 27, 2023 •

edited

Loading

Dgzt commented Apr 30, 2023 •

edited

Loading

Dgzt commented Apr 30, 2023 •

edited

Loading

antzGames commented May 1, 2023 •

edited

Loading

JamesTKhan commented May 3, 2023 •

edited

Loading