Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable MSAA by default, with CLI to disable #155

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Conversation

JamesTKhan
Copy link
Owner

This PR sets the Editor to use 8 samples of MSAA by default. It can be disabled by program arguments for users with lower end hardware. This also sets the depth buffer to be 24 whereas the default was 16 (libGDX default) before.

@JamesTKhan
Copy link
Owner Author

JamesTKhan commented Apr 24, 2023

@Dgzt I guess we think alike hahah. I did not even see your other PR yet that changed the samples as well!

@Dgzt
Copy link
Collaborator

Dgzt commented Apr 24, 2023

@Dgzt I guess we think alike hahah. I did not even see your other PR yet that changed the samples as well!

Yes :). But this changes are more elegant then my changes, so I closed my PR.

@Dgzt
Copy link
Collaborator

Dgzt commented Apr 24, 2023

Maybe later we should use argument parser (like args4j) if we will have more arguments, not only noMSAA.

@JamesTKhan
Copy link
Owner Author

JamesTKhan commented Apr 24, 2023

Maybe later we should use argument parser (like args4j) if we will have more arguments, not only noMSAA.

Yep we probably will have more arguments down the road, I am thinking of adding an argument to enable GL30 features. Now that WebGL2 PR is merged to libGDX we can make some really nice enhancements to Mundus down the road

@JamesTKhan JamesTKhan merged commit 0fa4933 into master Apr 24, 2023
@JamesTKhan JamesTKhan deleted the default-msaa branch June 5, 2023 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants