Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix game object selection #140

Merged
merged 2 commits into from
Mar 1, 2023

Conversation

Dgzt
Copy link
Collaborator

@Dgzt Dgzt commented Feb 26, 2023

I've fixed the game object selection issue.

fix

But I reverted that feature that clear selected brush if change tab:
reverted

And I implemented 2 features/bugfixes:

  1. Show selected brush mode if you go back to the previous tab where you selected brush mode:
    previous_selected_brush

  2. Clear selected brush on tab if you push ESC button and clears brush mode:
    press_q

The merge request is too big, because I should convert ToolManager to kotlin (with built-in intellij converter) to call Mundus.postEvent method. So I just converted it to kotlin language and call Mundus.postEvent(ToolDeactivatedEvent()) in line 106.

@Dgzt Dgzt requested a review from JamesTKhan February 26, 2023 18:29
@Dgzt Dgzt added the bug Something isn't working label Feb 26, 2023
@Dgzt Dgzt changed the title Fix gameobject selection Fix game object selection Feb 26, 2023
@JamesTKhan JamesTKhan merged commit 167790c into JamesTKhan:master Mar 1, 2023
@Dgzt Dgzt deleted the fix-gameobject-selection branch April 11, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants