Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select with left button #137

Merged
merged 7 commits into from
Mar 10, 2023
Merged

Select with left button #137

merged 7 commits into from
Mar 10, 2023

Conversation

Dgzt
Copy link
Collaborator

@Dgzt Dgzt commented Feb 23, 2023

Very strange to me to select model/terrain/etc with right mouse button. I changed to left mouse button. What do you think?

@Dgzt Dgzt requested a review from JamesTKhan February 23, 2023 21:30
@Dgzt Dgzt added the enhancement New feature or request label Feb 23, 2023
@JamesTKhan
Copy link
Owner

JamesTKhan commented Feb 26, 2023 •
edited
Loading

I am open to adding this as an option to the Settings. Maybe a boolean/checkbox for "Left Click Select". Then, it would use the
PreferencesManager / MundusPreferencesManager to store and load the users preference setting and based on that setting, use left or right click. I added the pref manager a little while back because I was starting to move away from Kryo since Kryo is too fragile if you make any changes to it. Right now I use the preferences system to detect if the version has changed for a user in the UI.kt class processVersionDialog().

What do you think?

image

@Dgzt
Copy link
Collaborator Author

Dgzt commented Feb 27, 2023 •
edited
Loading

What do you think?

Good idea. I will do it soon.

@Dgzt Dgzt marked this pull request as draft March 2, 2023 12:18
@Dgzt Dgzt marked this pull request as ready for review March 2, 2023 15:45
@Dgzt
Copy link
Collaborator Author

Dgzt commented Mar 2, 2023

I added this option to the general settings:

image

@JamesTKhan JamesTKhan merged commit 99fada9 into JamesTKhan:master Mar 10, 2023
@Dgzt Dgzt deleted the select-with-left-button branch April 11, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesTKhan JamesTKhan JamesTKhan approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dgzt @JamesTKhan