Handle deleting of temp model files #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dgzt
approved these changes
Feb 21, 2023
I've tested this changes on Linux and work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When importing models, they are first moved into a temporary directory for fbx conversion, if needed. However, they are never deleted on import completion or if the import was cancelled. On my own machine the mundus temp directory had 1 gigabyte of temp data.
I have not added code to retroactively delete existing temp files, but this code will delete the temporary model files on either window close or import completion going forward.
Also adds code to 'reset' the import dialog, otherwise the import dialog when reopened shows the previous imported model.
Have not been able to test on Linux yet as my WSL is not working for some reason.