Make terrain assets reusable #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to make Terrain Assets place-able and re-usable. Before, once a terrain asset was removed from a scene, it became unusable and could not be placed ever again. This PR adds a button when inspecting a terrain asset to add it to the scene (like models). The PR also makes it possible to reuse the same terrain asset in the same scene (like models). This required a somewhat large refactor of the Terrain class. The terrain class behaved like a ModelInstance, which made it difficult to be reusable.
Instead the terrain class has been modified to behave more like a Model, and now TerrainComponent holds the ModelInstance reference (similar to ModelComponent) and transform data. Transform was removed from the Terrain class. This allows the asset/terrain to be reusable. Note that this does not COPY a terrain asset. If you modify one instance of the terrain, it will affect all instances (just like models).
This has a bonus of fixing a bug with terrain transforms where their positions sometimes do not update.
Untitled.24.mp4