Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scene name validation #113

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Scene name validation #113

merged 2 commits into from
Oct 19, 2022

Conversation

Dgzt
Copy link
Collaborator

@Dgzt Dgzt commented Oct 19, 2022

Currently we can add scene with empty name and I think it is not a good behavior.

With this fix we can not add new scene with empty or blank name:

image
image

@Dgzt Dgzt requested a review from JamesTKhan October 19, 2022 08:37
@JamesTKhan
Copy link
Owner

Good catch! I did not know empty scene names were being allowed.

@JamesTKhan JamesTKhan merged commit 6993368 into JamesTKhan:master Oct 19, 2022
@Dgzt Dgzt deleted the scene-name-validation branch October 19, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesTKhan JamesTKhan Awaiting requested review from JamesTKhan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Dgzt @JamesTKhan