Terrain Uber Shader #100
Merged
Terrain Uber Shader #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # editor/src/main/com/mbrlabs/mundus/editor/ui/modules/outline/OutlineRightClickMenu.kt
|
PR merge was delayed due to a hard to track down bug that only happened some times. Ended up being blending enabled on the context, Fixed by disabling blending on terrain shader. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the TerrainShader with TerrainUberShader. I have left the code for the legacy TerrainShader in tact for now but deprecated it. The new terrain shader eliminates branching as much as possible and falls more in line with libGDX shader architecture.
There should be no visual change in terrains with this PR. The reason for switching to an uber shader is performance, as the current approach would not scale well when more terrain features are implemented.