forked from DanAnkers/WsprryPi
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for 6 character Maidenhead grid locators #12
Open
gibmat
wants to merge
13
commits into
JamesP6000:master
Choose a base branch
from
gibmat:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure grid locators are either 4 or 6 characters long
Added some fixes identified by running through |
Hi gimbat -- I've been using your code on an RPi 2 for a few months now and it works well, all WSPRNet confirmations come through with my grid ID showing all 6 characters. Thanks for a much-wanted addition! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support to WsprryPi to use Maidenhead grid locators that are 6 characters long, rather than truncating any supplied locator to 4 characters. I based things off of the Fortran code in the wsprx code base, and it works for me on my Pi v1 based on reports I see on wsprnet. I couldn't find another implementation to compare with for equivalent output. (The wsprcode utility on K1JT's site won't produce output with a 6 character locator.)
I also did some simple code cleanup and ran everything through clang-format to make it more readable.
73,
Mathias K0WBG