This repository has been archived by the owner on Jan 14, 2019. It is now read-only.
test: change babel sourceType to unambiguous with FixtureTester #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armano2
force-pushed
the
babel-unambiguous
branch
2 times, most recently
from
e822680
to
a03c4ab
Compare
armano2
force-pushed
the
babel-unambiguous
branch
from
188ff24
to
2f143ae
Compare
armano2
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes babel sourceType to unambiguous, additionally i found out that javascript/basic tests are not executed
FixturesTesteris doing what this messy code infixures-to-test.tswas doing with additional check if files test directory is present, this make code easier to read and understundsourceType
unambiguous:Babel added autodetection of sourceType, with that i was able to remove most of
parseWithSourceTypeModuleand leave it in only 4 filesi renamed this property to
ignoreSourceTypeand changed logic to ignore source type comparison instead of not doing comparison at all.there is one more issue with autodetection in babel: babel/babel#9213
@JamesHenry what do you think about this?
those changes got extracted from #52