Skip to content

NTO-2269 Remove references to Epoch#9

Merged
sorinarusu merged 2 commits into
masterfrom
nto-2269
Jul 11, 2025
Merged

NTO-2269 Remove references to Epoch#9
sorinarusu merged 2 commits into
masterfrom
nto-2269

Conversation

@sorinarusu
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@akhumphrey akhumphrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's absolutely fine to stop here, but we could potentially do more if you're keen. I looked back at the original commit which introduced this functionality (2e51fa9), and noticed that several other methods were added at the same time as getEpoch().

Grepping for each of them, it looks like only getTotalResults() is still in use in deepwell, so we could potentially also remove getHydrationQuery(), getHydratedFromCollection() and getHydrated() at the same time.

What do you reckon?

@sorinarusu
Copy link
Copy Markdown
Author

sorinarusu commented Jun 27, 2025

I think we can remove getTotalResults() too. I searched for the use of this function too in deepwell and I can't find where it is used. There some calls to a getTotalResults function, but the calls are to one of the 2 functions defined in either

  • lib/netsuite/Response/NetsuiteCollection.php or
  • lib/task/queueWorkerTask.class.php

Screenshot 2025-06-27 104036

Comment thread lib/Doctrine/Table.php

return $results->rowCount();
}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hellfire

@sorinarusu sorinarusu merged commit fcd7d20 into master Jul 11, 2025
2 checks passed
@sorinarusu sorinarusu deleted the nto-2269 branch July 11, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants