-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add function in namespace snippet #116
feat: add function in namespace snippet #116
Conversation
Reviewer's Guide by SourceryThis PR adds support for documenting functions within namespaces by introducing a new documentation tag '::: doxy..namespace.function'. The implementation includes new finder methods for namespaces and namespace functions, along with corresponding generator functionality. Class diagram for updated finder methodsclassDiagram
class Finder {
+doxyClass(project, className: str)
+doxyNamespace(project, namespace: str)
+doxyClassMethod(project, className: str, methodName: str)
+doxyNamespaceFunction(project, namespace: str, functionName: str)
+doxyFunction(project, functionName: str)
}
note for Finder "Added doxyNamespace and doxyNamespaceFunction methods"
Class diagram for updated generator snippetsclassDiagram
class GeneratorSnippets {
+doxyNamespaceList(snippet, project: str, config)
+doxyNamespaceFunction(snippet, project: str, config)
+doxyFileList(snippet, project: str, config)
}
note for GeneratorSnippets "Added doxyNamespaceFunction method"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @barnou-psee - I've reviewed your changes - here's some feedback:
Overall Comments:
- Error message in doxyNamespaceFunction references 'Class' instead of 'Namespace' in the error text - this should be updated to match the actual functionality
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
e7ffc19
to
33a83c0
Compare
33a83c0
to
db1fb4d
Compare
Thank you for the help, merged in https://pypi.org/project/mkdoxy/1.2.6/ |
Summary by Sourcery
Add functionality to support namespace-specific function documentation by introducing
doxyNamespaceFunction
infinder.py
and updatinggeneratorSnippets.py
to handle this new feature. Update the documentation to reflect these changes.New Features:
doxyNamespaceFunction
in thefinder.py
to locate functions within a specific namespace.Enhancements:
namespace.function
ingeneratorSnippets.py
to handle namespace-specific function documentation.Documentation:
functions.md
to include documentation for the newdoxy.<project>.namespace.function
tag, explaining its usage and parameters.