Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: brief description in detailed if there is no detailed description; change the Detailed Description header level #114

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

DmitriyMarin
Copy link
Contributor

@DmitriyMarin DmitriyMarin commented Sep 11, 2024

This PR fixes two issues:

Summary by Sourcery

Fix the incorrect usage of brief description in the property module and adjust the header level of 'Detailed Description' in the member.jinja2 template to ensure proper document structure.

Bug Fixes:

  • Fix the issue where a brief description was incorrectly used instead of a detailed description in the property module.

Enhancements:

  • Change the header level of 'Detailed Description' in the member.jinja2 template from a first-level header to a second-level header to maintain consistency with the document structure.

This commit fixes the issue JakubAndrysek#113: No brief description in detailed output for members if there is no detailed description
Copy link

sourcery-ai bot commented Sep 11, 2024

Reviewer's Guide by Sourcery

This pull request addresses two issues: it modifies the property.py file to use the brief description when there is no detailed description, and it adjusts the header level for the "Detailed Description" section in the member.jinja2 template.

File-Level Changes

Change Details Files
Change the XML element used to check for description presence
  • Replace 'detaileddescription' with 'briefdescription' in the XML find method
  • This change affects the 'has' method of an unnamed class
mkdoxy/property.py
Adjust the header level for the 'Detailed Description' section
  • Change the header from level 1 (#) to level 2 (##)
  • This modification ensures proper hierarchy in the document structure
mkdoxy/templates/member.jinja2

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DmitriyMarin - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a brief comment in property.py explaining the rationale for switching from 'detaileddescription' to 'briefdescription'. This will help with future maintenance and understanding of the code.
  • It would be beneficial to include tests that verify the behavior remains correct after changing from 'detaileddescription' to 'briefdescription' in the has() method.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@JakubAndrysek JakubAndrysek merged commit 7053801 into JakubAndrysek:main Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants