Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Storybook 8 support #28

Merged
merged 2 commits into from
Mar 24, 2024
Merged

Conversation

thebspin
Copy link
Contributor

Hi, attempted to add SB 8 support.
Had to update/change a few packages and they deprecated support for *.stories.mdx files so also had to update this.

I still see the routers being underline when being set active and the clicks still emit an action

Copy link

vercel bot commented Mar 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
storybook-addon-angular-router ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2024 11:08pm

@Jakob-em Jakob-em added the minor Increment the minor version when merged label Mar 24, 2024
@Jakob-em
Copy link
Owner

Thanks a lot for the PR @thebspin. I updated to 8.0.4 and removed one of the outdated peer dependencies. LGTM!

@Jakob-em Jakob-em merged commit 6820f12 into Jakob-em:main Mar 24, 2024
2 checks passed
@thebspin
Copy link
Contributor Author

The release pipeline seemed to have failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants