Fix compilation on Windows #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the previous dependency versions, the build always failed during the documentation tasks; this was due to an incompatibility between Kotlin and Gradle (see Kotlin/dokka#428). Update Kotlin to 1.4.30 (not the latest version, but the latest version available in IDEA). KTLint could not be updated to 0.41.0 because of some weird behavior with the plugin (sample/Main.kt indentation is marked as incorrect). Update the configuration blocks, as well (the `dokka` block is no more).
Without this, if Windows fails then we won't test Mac.
I'm honestly not sure why this is required, since Kotlin files are supposed to always be UTF-8. Without this, though, the build fails on Windows due to all special table characters being turned into ???. Fixes JakeWharton#29.
|
Note that this work is meant to be merged after my other PR is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file encoding needs to be set to UTF-8. I'm honestly not
sure why this is required, given that Kotlin files are supposed to
always be UTF-8.
Fixes #29.