-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Characters don't work on Windows #29
Comments
I'm honestly not sure why this is required, since Kotlin files are supposed to always be UTF-8. Without this, though, the build fails on Windows due to all special table characters being turned into ???. Fixes JakeWharton#29.
All fixed in my PR ;) If you could let me know if you are able to merge and release it soonish that would be super helpful; otherwise I'll need to fork it to release the project I've been working on (or, of course, use a different table renderer... but I like this one:) ). |
I just realized that the issue is actually with the compilation of the test files; my test files also use the special non-ASCII characters, and setting the encoding correctly makes the tests pass on Windows. So I'm not blocked in any way by this ticket. I hope that it can still be a useful contribution for you. Thanks again for the amazing project! :) |
Any updates to this? I've recently ran into this too. |
@jakepurple13 If you're running into this while testing your own project, I would just set |
I'm trying to make a gradle plugin using this. And I'm also using gradle kts and couldn't find a way to set the Edit: tasks.withType<JavaCompile>().let {
it["compileJava"].options.encoding = "UTF-8"
it["compileTestJava"].options.encoding = "UTF-8"
} But it's still not working. |
I'm sorry, I have no experience writing gradle plugins 🤷 . All my project required was this one simple line: https://github.com/garfieldnate/Weka_AnalogicalModeling/blob/master/build.gradle#L12 |
It appears that the unicode characters are not generated or recognized correctly on Windows.
I've opened a PR to add a GitHub action to build on Windows, Linux and Mac; the Windows build always fails, though, because the tables look like this:
See build results here.
The text was updated successfully, but these errors were encountered: